fix(lib-dynamodb): remove log filter overrides #7009
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smilkuri
approved these changes
Apr 14, 2025
trivikr
approved these changes
Apr 14, 2025
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the log function overrides set by the DynamoDBDocumentClientCommand abstract base class.
The overwriting of the log functions caused stale values to be logged under concurrent invocation.
The original reasoning for having the logging overrides does not apply to DynamoDB because it currently has no sensitive fields and is not likely to add any. Even if it did, it would not be inside a AttributeValue <-> JS Object mapping, so the base dynamodb client's log filter would still apply to the document client in such cases.